nbrooke
commented
2 years ago Looks good in general, couple minor tweaks I'd make before merging (Don't think we need a re-review after these if we just make them and merge):
- Button on the "Login" screen just says "Button", should probably change it to "Log in" or something.
- Posts in the table view are selectable and highlight, but don't do anything. Should problaby disable selection.
- "SwifterManager" is not a great name in a couple of regards: Our more modern naming convention of things would make this a "Service" (or maybe in this case call it a "Server" to make it clear that's what it is filling in for), and If you don't know what "Swifter" does as a library the name of the class doesn't tell you much. I'd call it something more like "ExampleNetworkServer"
Some other things we might want to consider having examples of if we do want to spend a bit more time fleshing this out:
- The params just being a raw dictionary rather than a struct
- Adding a custom finalize implementation
- Adding a custom decode implementation
Some larger things we might want to think about:
- I know it's not really core to showing off Netable itself, but it would be nice if the "create post" API actually did something to the state of the posts when you get them. Seems like it'd be fairly straightforward to just decode the post in the "server" and keep like an in memory list of create posts and then when it's doing the "get post" send back both the json data AND the in memory posts.
- Seems like with iOS 13 as the min platform we should be able to use SwiftUI if we want. AIUI It's only if we're supporting 12 that we need UIKit example code to make it possible to runt he test app on 12, but I'm pretty sure we already dropped 12 support.
brendanlensink
Fixes #91
I would have prefferred to make this with SwiftUI, but as long as we're supporting iOS 13 I think it makes sense to keep this with UIKit to stand a little bit better of a chance of detecting if we break something.
This is a pretty simple 'app' with little to no UI. We could spend some more time making it look nicer and filling in some more complex examples, but I didn't want to go too far without validating that this is a good start.
I think we might want to also add some more elaborate examples of tricky situations we'd run into with other projects, but couldn't come up with any good examples to start with. Any suggestions?