search

stef / pbp

salty privacy
Other
53 stars 5 forks source link

Port to Python 3 #20

Closed adelq closed 6 years ago

adelq commented 6 years ago

A port of the project to Python 3. Fully compatible with Python 2.

Also, it needs to wait on https://github.com/dnet/pysecstr/issues/3.

adelq commented 6 years ago

@stef, this pull request is ready to go, and SecureString has been updated in PyPI to make this possible. As far as I have tested, it works flawlessly in Python 2.7, 3.4, 3.5, and 3.6, so they have been added to Travis CI.

One particular test (test_sign_fail) fails when the generated input has a null byte (which happens occasionally), it actually works though.

stef commented 6 years ago

thanks a lot! can i ask you why you are doing this? i have little time to review this the next week, will have to revisit this only after, i hope you don't mind.

adelq commented 6 years ago

No problem!

I found this project by coincidence, and the concept of a hackable, simpler PGP/GPG built on standard crypto libraries was really appealing to me.

No worries, take your time!

adelq commented 6 years ago

thanks for taking a look, I answered in the comments

stef commented 6 years ago

thanks for the hard work! great job. hope you enjoy pbp ;)

adelq commented 6 years ago

thanks!