search

stefanbirkner / system-rules

A collection of JUnit rules for testing code which uses java.lang.System.
http://stefanbirkner.github.io/system-rules
Other
546 stars 71 forks source link

Update lib-parent to version 14 #76

Closed diabonas closed 4 years ago

diabonas commented 4 years ago

Building with Maven 3.6.2 currently fails with

[ERROR] Failed to execute goal org.codehaus.mojo:findbugs-maven-plugin:3.0.1:findbugs (findbugs) on project system-rules: Unable to parse configuration of mojo org.codehaus.mojo:findbugs-maven-plugin:3.0.1:findbugs for parameter pluginArtifacts: Cannot assign configuration entry 'pluginArtifacts' with value '${plugin.artifacts}' of type java.util.Collections.UnmodifiableRandomAccessList to property of type java.util.ArrayList -> [Help 1]

This is resolved in FindBugs version 3.0.4 and newer, so update lib-parent to a version including this fix. Using lib-parent version >14 breaks the current CI setup due to requiring a more recent Maven version.

diabonas commented 4 years ago

The first commit fixes the failing Travis CI build by reworking the OpenJDK 6 setup, which is necessary to unbreak #75 as well.

stefanbirkner commented 4 years ago

Thank you for your contribution and especially the pretty commit messges. I already merged your first commit: e638fdc5617d06add124b11e3924576cefec388e. I have to check a few things before I can merge the second commit, too.

stefanbirkner commented 4 years ago

In the meantime I inlined the lib-parent POM. For details see 4a6c78a31d23333058522320304bb7e7a39231db Therefore i updated the FindBugs Maven plugin directly in System Rules' POM: 6bf863bc7a439c98fec38c9aa81b4eaf12a81f53