search

stefanbschneider / mobile-env

An open, minimalist Gymnasium environment for autonomous coordination in wireless mobile networks.
https://mobile-env.readthedocs.io
MIT License
109 stars 29 forks source link

Feature Request: migrate from gym to gymnasium #26

Closed elliottower closed 1 year ago

elliottower commented 1 year ago

Hi, this repository is currently listed in the gymnasium third party environments but we are cleaning the list up to only include maintained gymnasium-compatible repositories.

Would it be possible for it to be upgraded from gym to gymnasium? Gymnasium is the maintained version of openai gym and is compatible with current RL training libraries (rllib and tianshou have already migrated, and stable-baselines3 will soon).

For information about upgrading and compatibility, see migration guide and gym compatibility. The main difference is the API has switched to returning truncated and terminated, rather than done, in order to give more information and mitigate edge case issues.

stefanbschneider commented 1 year ago

Hi, thanks for notifying. I will try to update to the latest Gymansium version as soon as possible, closing the issue once it's ready.

stefanbschneider commented 1 year ago

@elliottower I just merged the changes for switching from gym to gymnasium and released mobile-env 2.0.0, which supports the latest gymnasium version.

Should I make a PR to update mobile-env in your third-party env list? Or will you or someone else take care of that?

elliottower commented 1 year ago

@elliottower I just merged the changes for switching from gym to gymnasium and released mobile-env 2.0.0, which supports the latest gymnasium version.

Should I make a PR to update mobile-env in your third-party env list? Or will you or someone else take care of that?

Great to hear, thanks. And either way, I am happy to do it myself but if you want to contribute you can as well. If you wanted to you could control the wording and headline and such. We sort by number of stars and the formatting should match (not too long of a description for example) but it shouldn’t be too hard to figure out if you’re interested.

stefanbschneider commented 1 year ago

@elliottower Great! I opened a PR to update the docs here: https://github.com/Farama-Foundation/Gymnasium/pull/474