search

stefankoegl / python-json-pointer

Resolve JSON Pointers in Python
https://python-json-pointer.readthedocs.org/
Other
140 stars 43 forks source link

Add method and add classmethod tag #46

Closed PeterlitsZo closed 2 years ago

PeterlitsZo commented 2 years ago

Set get_part as a classmethod, and add method get_parts

For: #36, #45

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling a5e9f91e59e54bf1889a7eb2bfb24539a281e181 on PeterlitsZo:patch-1 into 7d146bd7caf196bd04b44bdb6d395e91256fa88c on stefankoegl:master.

PeterlitsZo commented 2 years ago

Well, I will fix it.

PeterlitsZo commented 2 years ago

How can I deal with coverage? I think I need some help~

PeterlitsZo commented 2 years ago

Do I need to update tests.py?

PeterlitsZo commented 2 years ago

Looks great! but method get_part's usage changed. If you want to pull this, I think it is better to change version.

stefankoegl commented 2 years ago

Thanks for the contribution!

but method get_part's usage changed.

Do you see any case that was valid before but is failing now? It should still be ok to call the classmethod from an instance, right?

PeterlitsZo commented 2 years ago

OMG, you are so smart. Right at total!

stefankoegl commented 2 years ago

Thanks for your contribution :)