search

stefankueng / grepWin

A powerful and fast search tool using regular expressions
https://tools.stefankueng.com/grepWin.html
GNU General Public License v3.0
1.72k stars 179 forks source link

improve presentation of matching results and related #451

Closed lifenjoiner closed 6 months ago

lifenjoiner commented 6 months ago

https://github.com/stefankueng/grepWin/issues/83, https://github.com/stefankueng/grepWin/issues/117 and more. See the descriptions of each commit.

stefankueng commented 6 months ago

why do you call it "move"? Isn't this the column of the line?

lifenjoiner commented 6 months ago

why do you call it "move"? Isn't this the column of the line?

Many people take \t as indentations. And how many columns a \t counts is decided by the editor they use. For example, :

    int i = 0;

Here we can only say int starts from the 2nd char. In an editor, if the \t width is defined 4, then it is the 5th column; if 8, it is the 9th column.

BTW: Scintilla based editors, Sublime Text, UltraEdit and Vim, that I checked, works in this way. MS Notepad is the only one that I know of counting \t as 1 column but display it with 8 columns.

lifenjoiner commented 6 months ago

I called it "column" at first. "Position" has been used as posMatch in SearchFile. "Offset", in many scenarios, is defined beginning from the start of the file. They both give me the impression that from the start of the file. Finally, "move" came into my mind, represents the times of caret moves.

stefankueng commented 6 months ago

while "caret move" would be better than just "move", I don't think either is good. It's not a common term for what it is used for. I myself had no idea what this "move" should be before checking the source code. So this has to be changed to "column" or "line offset", anything but "move"...

lifenjoiner commented 6 months ago

None is perfect. I don't have a better one. So, it will be changed back to "column", and with explanation "line offset".