search

stefankueng / grepWin

A powerful and fast search tool using regular expressions
https://tools.stefankueng.com/grepWin.html
GNU General Public License v3.0
1.72k stars 179 forks source link

Replace does nothing with binary files #465

Closed arukateru closed 4 months ago

arukateru commented 5 months ago

Replace text in binary files does nothing, it just flashes for a second and does not touch the files

lifenjoiner commented 5 months ago

Try the latest Artifacts from https://github.com/stefankueng/grepWin/actions. I had improved it.

arukateru commented 5 months ago

Try the latest Artifacts from https://github.com/stefankueng/grepWin/actions. I had improved it.

This version corrupts the binary files

lifenjoiner commented 5 months ago

Prove it.

To be honest, binary files vary. It is highly likely that they are not correctly decoded, BTW. You should know that, and don't expect it works in the same way like text files. Only do it when you know exactly what you are doing, and always make backups.

arukateru commented 5 months ago

Prove it.

To be honest, binary files vary. It is highly likely that they are not correctly decoded, BTW. You should know that, and don't expect it works in the same way like text files. Only do it when you know exactly what you are doing, and always make backups.

It removes two bytes from the file for some reason, hence corrupting it

https://github.com/stefankueng/grepWin/assets/84914212/f04a2a5c-e227-4a99-9247-2b1ae4870ec2

lifenjoiner commented 5 months ago

Thanks for your feedback! Should be fixed by https://github.com/stefankueng/grepWin/commit/dc586b1fcea22af8ed72999ff3ebc0ec5534dfb3. Try the latest.