search

stefanopagliari / bibnotes

360 stars 30 forks source link

highlights formatting not working anymore on Zotero 5 ("old" version) #49

Open Rhydderch opened 2 years ago

Rhydderch commented 2 years ago

Hi, Since the 9.0.0 version the formatting does not work anymore.

To help debug, I provide

link: https://we.tl/t-6igTomP1Zv

What might be the bug? Is it possible to fix it?

Rhydderch commented 2 years ago

I tried installing old 0.8 and 0.9 versions and I get the same problem: only the last highlight of the extracted note is formatted correctly. So, weirdly enough, the formatting has stopped working for me regardless of the version I am on. I have no idea why this is happening. Also, I'm on Obsidian v0.13.23 image

Also important to note: I use zotero version 5

Rhydderch commented 2 years ago

Updating to the Zotero Beta fixed the above issues for new extracted highlights with the latest version of Zotfile. However, for old extractions of notes by zotfile, the same issue persists. Deleting the previous note, Re-extracting the highlights using zotfile, and then importing them back in Obsidian using bibnotes works.

So - I think - the issue lies in the way bibnotes handles note highlights from previous versions of Zotero.

stefanopagliari commented 2 years ago

Hi @Rhydderch, sorry but I did not have time to check this yet. To give a bit of background on how I coded the extraction of notes from zotfile, I basically installed the latest version of zotfile on the Zotero Beta and worked the default settings. I did not get a chance to test older versions of Zotfile and Zotero. I think you may be right that in these older versions the markers identified by Bibnotes to recognise an annotation extracted from Zotfile are not present. If you have included in your initial submission a json file of a note extracted from this older version, I should be able to detect the difference but this may take a few more days

Rhydderch commented 2 years ago

Hi @stefanopagliari . No worries if you cannot get to the bottom of this anytime soon. The beta of zotero is actually quite good and I am happy bibnotes is working well with it :)!

I did include the json file from the old version so perhaps, if that is the root of the problem like we think it is, the user could specify which zotero version he uses (5.0 or beta).