search

stefanzweifel / git-auto-commit-action

Automatically commit and push changed files back to GitHub with this GitHub Action for the 80% use case.
MIT License
1.92k stars 224 forks source link

Update node version to node20 #300

Closed ryudaitakai closed 9 months ago

ryudaitakai commented 10 months ago

Node20 was added to Actions Runner on v2.308.0. Node16 will be end of life on 11 Sep 2023.

This PR updates the default runtime to node20, rather than node16

ryudaitakai commented 10 months ago

(I didn't know that it was possible to point v4 back to a non-latest version and also about GHES...!)

I think It's better to do like last time you upgrade the node.js version. https://github.com/stefanzweifel/git-auto-commit-action/issues/246 Node.js 20 will enter long-term support (LTS) in October so it's good to wait for 2 or 3 months.

vosscodes commented 9 months ago

👋 thanks for taking this on!

IMO it would be good to release a new major version as done in other actions like those used to configure AWS credentials which would allow this to be released now rather than in a few weeks or months :)

stefanzweifel commented 9 months ago

@vosscodes Thanks for the feedback. Does the lack of merging this PR block you in any way?

I know that I could simply create a new major version; but IMO I don't like tagging a new major version if the only thing that changes is the node version the action runs on; which isn't even relevant for this package as node just triggers a bash script. (I mostly work in PHP where breaking changes made in packages are relatively rare)

But maybe that's just something I have to deal with and release a new major version every 12 months without changing the API of the Action. 🤔

vosscodes commented 9 months ago

nope! I wouldn't say it blocks us at all, and you should feel free to hold off as you see fit. we're very strict on the things we run, even when it's a github action that clearly is not at risk by being on node 16.

I definitely agree that this:

But maybe that's just something I have to deal with and release a new major version every 12 months without changing the API of the Action.

is ridiculous and should never be a real thing that happens 😅

we've noted this as an exception for now, but it'd still be helpful to figure out a way to ensure we have an upgrade path to new LTS node versions when released - which, for what it's worth, node 20 security support would give you 30 months without needing a new major version upgrade :)

stefanzweifel commented 9 months ago

@vosscodes Thanks for understanding my reluctancy here.

Will probably bite the bullet here and create a new major version tomorrow.

vosscodes commented 9 months ago

appreciate you understanding us as well - we're on board with whatever you decide to go with!