search

steffow / meteor-accounts-saml

SAML SP tested with OpenAM
27 stars 29 forks source link

changes needed for encrypted assertions #31

Closed gerbsen closed 6 years ago

gerbsen commented 6 years ago

So, I just got the changes from @anicoa and I integrated them in a fresh develop branch. Since it was a little bit difficult to actually merge since due to tabs/spaces/newlines etc. I would like to have @anicoa to have a look at it and give his go (he's the one who develop the fix). In the meantime you could check if this fits with your standards!

gerbsen commented 6 years ago

Okay, we've testet this on our side. And we think it's good to go. What do you think?

steffow commented 6 years ago

I’ll have look. I’m a bit busy at the moment, but will come back to you.

On 7. Apr 2018, at 14:29, gerbsen notifications@github.com wrote:

Okay, we've testet this on our side. And we think it's good to go. What do you think?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/steffow/meteor-accounts-saml/pull/31#issuecomment-379465896, or mute the thread https://github.com/notifications/unsubscribe-auth/AGosJeF7nt27ej32nDXj7ZzzIOX0AzKbks5tmLEhgaJpZM4TDpi_.

gerbsen commented 6 years ago

Any chance yet to look at it?

gerbsen commented 6 years ago

Okay, I added a section for encryption now. Does that make sense?

gerbsen commented 6 years ago

@steffow from our side this is done. okay to merge?

steffow commented 6 years ago

Thanks. Published to Atmosphere. Thanks also for bearing w my time management ;-)