steffow / meteor-accounts-saml

SAML SP tested with OpenAM
27 stars 29 forks source link

SAML Integration missing hash algorithm #8

Closed gerbsen closed 7 years ago

gerbsen commented 7 years ago

hey there, I've this problem which I described here:

Sorry, an annoying error occured
Error: hash algorithm 'http://www.w3.org/2001/04/xmlenc#sha512' is not supported
Close Window

but no one is answering, I thought maybe let's try it here.

any help is very much appreciated! thanks, daniel

gerbsen commented 7 years ago

@steffow hey sorry for being annoying

steffow commented 7 years ago

Think this is an issue w the xml-crypto NPM which doesnt support SHA512 https://github.com/ZheFeng/xml-crypto https://github.com/ZheFeng/xml-crypto

On 5 Apr 2017, at 23:28, gerbsen notifications@github.com wrote:

@steffow https://github.com/steffow hey sorry for being annoying

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/steffow/meteor-accounts-saml/issues/8#issuecomment-292002733, or mute the thread https://github.com/notifications/unsubscribe-auth/AGosJaCCmbDmqwmmKsaDaVXznTVi4gmVks5rtAeCgaJpZM4Mu4WQ.

gerbsen commented 7 years ago

hey @steffow, thank you very much for this information! If I go to the original repo (https://github.com/yaronn/xml-crypto) SHA 512 is listed as supported. Do you have any idea where I should turn to?

steffow commented 7 years ago

Indeed. Would need to check which source npm module is build from. Anyway, you have the source....

Steffo

On 7 Apr 2017, at 18:45, gerbsen notifications@github.com wrote:

hey @steffow, thank you very much for this information! If I go to the original repo (https://github.com/yaronn/xml-crypto) SHA 512 is listed as supported. Do you have any idea where I should turn to?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

steffow commented 7 years ago

I’ve just updated the package. If that doesn’t resolve yr issue, can you send me sth to reproduce?

On 7. Apr 2017, at 18:45, gerbsen notifications@github.com wrote:

hey @steffow https://github.com/steffow, thank you very much for this information! If I go to the original repo (https://github.com/yaronn/xml-crypto https://github.com/yaronn/xml-crypto) SHA 512 is listed as supported. Do you have any idea where I should turn to?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/steffow/meteor-accounts-saml/issues/8#issuecomment-292588851, or mute the thread https://github.com/notifications/unsubscribe-auth/AGosJWba0dxa2HpzEHAAMi_4I8sb9qGzks5rtmgzgaJpZM4Mu4WQ.

gerbsen commented 7 years ago

Hey @steffow, thank you! So far I've installed Rocket.Chat with this Dockerfile. Will have to see how I can integrate this... Are you associated with Rocket.Chat, e.g. do you see any chance they will integrate your version bump into there release?

steffow commented 7 years ago

No. I have no relation w them. Seems as if if they forked the package. Main changes are in https://github.com/RocketChat/Rocket.Chat/blob/develop/packages/meteor-accounts-saml/package.js https://github.com/RocketChat/Rocket.Chat/blob/develop/packages/meteor-accounts-saml/package.js.

On 12. Apr 2017, at 11:42, gerbsen notifications@github.com wrote:

Hey @steffow https://github.com/steffow, thank you! So far I've installed Rocket.Chat with this Dockerfile https://github.com/RocketChat/Docker.Official.Image/blob/a721d599218803d2acb27f92b11d2cdcf0a226d5/Dockerfile. Will have to see how I can integrate this... Are you associated with Rocket.Chat, e.g. do you see any chance they will integrate your version bump into there release?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/steffow/meteor-accounts-saml/issues/8#issuecomment-293526700, or mute the thread https://github.com/notifications/unsubscribe-auth/AGosJRMvZ1t9VNDbLlYNeA143v0Vaoy2ks5rvJx2gaJpZM4Mu4WQ.

gerbsen commented 7 years ago

So if I understand this correctly, I would need them to change to xml-crpyto to 0.9.0 pray that it does break anything else? (Sorry, but I'm not really a JS developer) But your help is very much appreciated!

steffow commented 7 years ago

Prob a good idea to grab all the new npm’s. But yes, that’s all I did. I couldnt test if it resolves yr missing hash issue though.

So use:

Npm.depends({ "xml2js": "0.4.17", "body-parser": "1.17.1", "sax": "1.2.2", "xmlbuilder": "8.2.2", "ejs": "2.5.6", "async": "2.3.0", "lodash":"4.17.4", "xpath": "0.0.24", "node-forge": "0.7.1", "xpath.js": "1.0.7", "xmldom": "0.1.27", "connect": "3.6.0", "querystring": "0.2.0", "xml-encryption": "0.10.0", "xml-crypto": "0.9.0" });

Also, “random” must be included in server packages.

On 12. Apr 2017, at 11:56, gerbsen notifications@github.com wrote:

So if I understand this correctly, I would need them to change to xml-crpyto to 0.9.0 pray that it does break anything else? (Sorry, but I'm not really a JS developer) But your help is very much appreciated!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/steffow/meteor-accounts-saml/issues/8#issuecomment-293530008, or mute the thread https://github.com/notifications/unsubscribe-auth/AGosJZHp-qDQdTpyLEYFdrqnhRALF2pxks5rvJ_GgaJpZM4Mu4WQ.

steffow commented 7 years ago

I'm closing this issue as no test case is available; Rocket apparantly modified the code: https://github.com/RocketChat/Rocket.Chat/blob/develop/packages/meteor-accounts-saml/CHANGELOG.md