stellar / freighter

Stellar browser extension
81 stars 25 forks source link

QA Freighter v5.25.0-beta.0 #1622

Closed sdfcharles closed 1 week ago

sdfcharles commented 3 weeks ago

Image

Image

Account Menu and Network Menu should match the max-width of the container

sdfcharles commented 3 weeks ago

Image Image Image Image Image Image

can we remove the additional padding on these screens?

sdfcharles commented 3 weeks ago

Image

sdfcharles commented 3 weeks ago

Image

can we update this styling to match the Manage Assets screen? (the above is when you go to swap and change an asset)

aristidesstaffieri commented 3 weeks ago

Nice thanks @sdfcharles @piyalbasu I've started this PR for QA https://github.com/stellar/freighter/pull/1624

aristidesstaffieri commented 3 weeks ago

Image Image Image Image Image Image

can we remove the additional padding on these screens?

Removed this padding in d82958f1e4c0f599c051552e830b9feff08ccc41

aristidesstaffieri commented 3 weeks ago

Image

Image

Account Menu and Network Menu should match the max-width of the container

Applied same max width in 0f12c6cd870c4ab579210f9e4d259116c6861908

aristidesstaffieri commented 3 weeks ago

Image

can we update this styling to match the Manage Assets screen? (the above is when you go to swap and change an asset)

Updates to make select asset styles consistent with manage asset styles in 5081e117e9f3779b939f212bc0f0259ec89f6a9f

Follow ups - We can probably make these two components 1 in the future. Do we want to treat long strings any differently here, like we see for ARST for example?

sdfcharles commented 2 weeks ago

yeah ideally, all the numbers are set to 2 decimals. the URLs can be truncated as well if they are too long.

aristidesstaffieri commented 2 weeks ago

yeah ideally, all the numbers are set to 2 decimals. the URLs can be truncated as well if they are too long.

I'm not sure if we can truncate after the second decimal without losing valuable info in some cases. Like maybe in some cases where it would be important to be able to see that you have 0.00000099 vs 0.00.