stellar / laboratory

89 stars 97 forks source link

inconsistent rendering of amounts in xdr viewer #180

Closed MonsieurNicolas closed 3 months ago

MonsieurNicolas commented 7 years ago

Amounts are returned with what seems to be an arbitrary form.

An amount value is returned as either a raw value or both fixed point and raw

Examples:

a trustline will show up with fields (right next to each other):

Lumens are returned the same way, for example in AccountEntry, you can see balance: 105032704 this is raw but in offers and payments it's the fixed point.

In general, I would imagine that any int64 that is supposed to be an amount should be rendered the same way.

vcarl commented 5 years ago

Is this still an issue? An XDR to reproduce would be helpful, I'm not quite sure what I'm looking for.

MonsieurNicolas commented 5 years ago

yes, you can look at this example

Account and Trustline have balance in raw only, like balance: 487864711 Offer amount and Trustline limit are mixed.

Looks like right now the only gap is on balance so rendering it as mixed would probably fix this issue

bartekn commented 5 years ago

Would be great to create type Amount int64 type in stellar-core so finding fields that should be rendered as amounts would be easier.

janewang commented 3 months ago

Fixed in new Lab