stellar / quickstart

Home of the stellar/quickstart docker image for development and testing
Apache License 2.0
195 stars 206 forks source link

Update soroban-dev image to use 20.0.0 versions #529

Closed sreuland closed 11 months ago

sreuland commented 11 months ago

Closes #527

sreuland commented 11 months ago

@sisuresh , this pr is trying to run tests against testnet with v20.0.0 core, seeing a failure in horizon ingestion during core catchup, reporting Local node's ledger corrupted during close:

time="2023-12-07T02:18:27.161Z" level=info msg="Tx: applying ledger 2888130 (classic phase: 0 component(s): [], soroban phase: 1 component(s): [{discounted txs:1, ops:1, base_fee:100}])" pid=233 service=ingest subservice=stellar-core
time="2023-12-07T02:18:27.166Z" level=info msg="Bucket: BucketIndex::createIndex() indexing individual keys in bucket buckets/tmp/bucket-323e2320f2ed60e5/tmp-bucket-2e1737c2313db2a3.xdr" pid=233 service=ingest subservice=stellar-core
time="2023-12-07T02:18:27.169Z" level=info msg="Bucket: BucketIndex::createIndex() indexing individual keys in bucket buckets/tmp/bucket-323e2320f2ed60e5/tmp-bucket-a19959efa9a9f7e6.xdr" pid=233 service=ingest subservice=stellar-core
time="2023-12-07T02:18:27.170Z" level=info msg="default: Application destructing" pid=233 service=ingest subservice=stellar-core
time="2023-12-07T02:18:27.206Z" level=info msg="default: Application destroyed" pid=233 service=ingest subservice=stellar-core
time="2023-12-07T02:18:27.342Z" level=error msg="default: Got an exception: Local node's ledger corrupted during close" pid=233 service=ingest subservice=stellar-core
time="2023-12-07T02:18:27.342Z" level=error msg="default: Please report this bug along with this log file if this was not expected" pid=233 service=ingest subservice=stellar-core
time="2023-12-07T02:18:27.347Z" level=error msg="Error in ingestion state machine" current_state="buildFromCheckpoint(checkpointLedger=2888191, skipChecks=false)" error="error preparing range: error starting prepare range: opening subprocess: error running stellar-core: error runing stellar-core catchup: exit status 1" next_state=start pid=233 service=ingest

do you think this is due to testnet on a prior version of P20? Wondering if I should temporarily disable testnet from the test matrix here in quickstart? i noticed the tests with v20.0.0 do work against pubnet.

sisuresh commented 11 months ago

The current version of core is not compatible with testnet, so that test should be skipped

leighmcculloch commented 11 months ago

If testnet isn't compatible with v20, we shouldn't update the testing image to v20. People use the testing image to track compatibility with testnet.

sisuresh commented 11 months ago

If testnet isn't compatible with v20, we shouldn't update the testing image to v20. People use the testing image to track compatibility with testnet.

Ah that's a good point. Is a different image used to connect to futurenet?

sreuland commented 11 months ago

If testnet isn't compatible with v20, we shouldn't update the testing image to v20. People use the testing image to track compatibility with testnet.

Ah that's a good point. Is a different image used to connect to futurenet?

futurenet isn't in the quickstart test matrix for the images, so, looks like not asserted/covered here, although that will be upgreaded imminently correct? at which point soroban-dev image would work with it.

leighmcculloch commented 11 months ago

Is a different image used to connect to futurenet?

Yes, the :soroban-dev image maintains compatibility with futurenet. There's no test run for futurenet specifically in this repo's CI setup, but that image tracks futurenet.

mollykarcher commented 11 months ago

Yes, the :soroban-dev image maintains compatibility with futurenet. There's no test run for futurenet specifically in this repo's CI setup, but that image tracks futurenet.

~Not as part of this change. But I think it might be worthwhile to rename these images to represent more clearly what networks they track; ex. :soroban-dev -> :futurenet and/or :latest -> :pubnet~

edit: nvm, just saw that you created this