search

stellar / quickstart

Home of the stellar/quickstart docker image for development and testing
Apache License 2.0
195 stars 206 forks source link

Soroban settings upgrade failure is silent #547

Closed sisuresh closed 5 months ago

sisuresh commented 10 months ago

https://github.com/stellar/quickstart/blob/974fb36f9df9bf0f0600367cdcc6ec7e5d4fb453/start#L509 can fail due to bad values being set, but supervisor just catches the error and continues. We should fail on startup here.

github-actions[bot] commented 9 months ago

This issue is stale because it has been open for 30 days with no activity. It will be closed in 30 days unless the stale label is removed.

sisuresh commented 7 months ago

We should prioritize this. The upgrade started failing silently after the v21 update.

github-actions[bot] commented 6 months ago

This issue is stale because it has been open for 30 days with no activity. It will be closed in 30 days unless the stale label is removed.