search

stellar / stellar-cli

CLI for Soroban contracts.
57 stars 48 forks source link

generate keys --no-fund #1407

Open chadoh opened 1 week ago

chadoh commented 1 week ago

What version are you using?

$ stellar --version
stellar 21.0.0 (c558dd92613d91a34011cf5105869a5f57af230c)
soroban-env 21.1.0 (8d76e4037417b80dc25c979cc44b8e1281e8ad84)
soroban-env interface version 90194313216
stellar-xdr 21.1.0 (4dcbb918edcd793fdf064b3ee28ceacc6bd9d1bb)
xdr curr (70180d5e8d9caee9e8645ed8a38c36a8cf403cd9)

What did you do?

stellar keys generate alice
image

What did you expect to see?

If no network provided, should generate keys and quietly skip funding.

If I provide --no-fund, same behavior.

What did you see instead?

Errors unless network provided

willemneal commented 1 week ago

This is because we flatten in the network and told clap we expected either rpc url and network passphrase or network. One solution is to remove from clap and instead the error will move from parsing to just when a the network needs to be resolved. So it should be an easy fix since we already handle the latter error.