[SDP-1370] Update `POST /disbursements` and `GET /disbursements` APIs to persist and return the Registration Contact Type - Githubissues

stellar / stellar-disbursement-platform-backend

Stellar Disbursement Platform Backend

Apache License 2.0

37 stars 22 forks source link

[SDP-1370] Update `POST /disbursements` and `GET /disbursements` APIs to persist and return the Registration Contact Type #452

Closed marcelosalloum closed 4 weeks ago

marcelosalloum commented 1 month ago

What

Update POST /disbursements and GET /disbursements APIs to persist and return the Registration Contact Type

Why

Address https://stellarorg.atlassian.net/browse/SDP-1370

Pending

Under the common interest of merging this PR quickly, I'll address the following tasks in a future PR:

[x] Add more unit tests to the POST /disbursements endpoint to ensure all types of registration contact type are persisted
[x] Slightly refactor data/disbursements.go to make the Selector query string into a common constant
[x] Update the custom validator of POST /disburements so it actually does something. Right now it's barely useful and only increases complexity for no reason.
[x] Remove the unused file migrate_1.1.6_to_2.0.0.sh.

EDIT: the tasks above were addressed in PR #454

Checklist

PR Structure

[x] This PR has a reasonably narrow scope (if not, break it down into smaller PRs).
[x] This PR title and description are clear enough for anyone to review it.
[x] This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).

Thoroughness

[x] This PR adds tests for the new functionality or fixes.
[x] This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

[x] No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
[x] No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
[x] No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
[x] No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

[x] This is not a breaking change.
[x] This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

[x] Does the deployment work after merging?

stellar-jenkins commented 1 month ago

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr452.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr452.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr452.previews.kube001.services.stellar-ops.com

stellar-jenkins commented 1 month ago

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr452.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr452.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr452.previews.kube001.services.stellar-ops.com

stellar-jenkins commented 1 month ago

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr452.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr452.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr452.previews.kube001.services.stellar-ops.com

stellar-jenkins commented 4 weeks ago

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr452.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr452.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr452.previews.kube001.services.stellar-ops.com

stellar-jenkins commented 4 weeks ago

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr452.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr452.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr452.previews.kube001.services.stellar-ops.com

stellar-jenkins commented 4 weeks ago

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr452.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr452.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr452.previews.kube001.services.stellar-ops.com

stellar-jenkins commented 4 weeks ago

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr452.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr452.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr452.previews.kube001.services.stellar-ops.com

stellar-jenkins commented 4 weeks ago

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr452.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr452.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr452.previews.kube001.services.stellar-ops.com

marcelosalloum commented 4 weeks ago

LGTM! Thank you for being so thorough with integration tests and migrations.

Our tests and migrations were good enough to break unless I added those changes, which is very reassuring.