search

stellar / stellar-docs

Documentation for Stellar
https://developers.stellar.org
Apache License 2.0
66 stars 132 forks source link

Add JS way to fetch claimable balance ID #1070

Closed Shaptic closed 4 weeks ago

stellar-jenkins commented 4 weeks ago

Preview is available here:
http://developers-pr1070.previews.kube001.services.stellar-ops.com

JFWooten4 commented 3 weeks ago

@Shaptic Thanks for implementing this! I have my own instance pending submission, and just wanted to circle around on this since I saw you used txResponse. As I understood the existing docs and community SDKs, method 1 is meant using only an analysis of the pre-submitted but built tx.

Clearly, you helped figure this one out and have gone the extra mile to implement it here! But I think it's intended to get fetched on the actual local object before touching Horizon. Just want to make sure we get this one right 🫱🏻‍🫲🏽

Shaptic commented 3 weeks ago

@JFWooten4 ah, very nice point!! I used txResponse out of laziness here as a way to get the transaction envelope, but you're absolutely correct that it's intended to enable calculation prior to submission entirely.