Closed alex-ketch closed 3 years ago
Thanks for this @alex-ketch.
Unfortunately, if we move the codemeta.json
file to src/
then we won't be adhering to the CodeMeta standard and thus loose any discoverability interoperability that may bring.
Instead, perhaps we need to do is have a src/manifest.ts
file with a Manifest
instance from which we generate the root codemeta.json
as part of the build and commit for each release.
Note that if we change the rootDir
back to src
then we also need to remove the src
from here:
https://github.com/stencila/encoda/blob/master/src/codecs/pandoc/binary.ts#L17-L39
I've updated the binary path per your comment just to see if that makes the tests pass.
Unfortunately, if we move the codemeta.json file to src/ then we won't be adhering to the CodeMeta standard and thus loose any discoverability interoperability that may bring.
I don't have enough insight re. the CodeMeta project to say definitively, but I read the location of the file being at the root more of as an example than a standard.
I don't have enough context to make a decision on how to move forward, but if you could point me in the right direction I can take a stab :) Is the manifest.ts
the way to go @nokome?
This is done (elsewhere).
ce34372095b0413c0cbf3043fab3b96feeb61cd3 broke the release as it caused TypeScript to output unexpected
dist
content structure.Root cause was due to the
codemeta.json
file living outside thesrc
directory, resulting inrootDir
value to resolve to.
.Manually setting
rootDir
to./src
does not help because this results in the following error:The fix was to move the
codemeta.json
file into thesrc
directory.