search

steos / jnafilechooser

A Java file chooser API that uses the Windows native dialogs if possible.
BSD 3-Clause "New" or "Revised" License
53 stars 14 forks source link

Update multi selection #23

Closed DJ-Raven closed 3 months ago

DJ-Raven commented 4 months ago

This PR update multi selections I see Issue #7 comment by @remcopoelstra. So please review this. Thank you.

steos commented 3 months ago

Thanks a lot!

DJ-Raven commented 3 months ago

@steos Please update this line https://github.com/steos/jnafilechooser/blob/06992e3bd5968323ba925af973fb4f09fc17e911/api/src/main/java/jnafilechooser/api/WindowsFileChooser.java#L226

to match the changes from PR #21

Apologies for the oversight I didn't check for the previous update before making my changes.

steos commented 3 months ago

isn't this already the current state on master?

DJ-Raven commented 3 months ago

Yes it's current on master.

steos commented 3 months ago

Sorry, I was not quite following. I think I got it now - so we should have as condition only this:

if (!defaultFilename.isEmpty()) {

instead of 

if (open && !defaultFilename.isEmpty()) {

right?

DJ-Raven commented 3 months ago

if (!defaultFilename.isEmpty()) {

yes

steos commented 3 months ago

done, thanks a lot!