stepancheg / rust-protobuf

Rust implementation of Google protocol buffers
MIT License
2.81k stars 382 forks source link

Build script does not honor RUSTC_WRAPPER #735

Closed RalfJung closed 1 month ago

RalfJung commented 3 months ago

This is the same issue as https://github.com/djc/rustc-version-rs/issues/45 and https://github.com/rust-lang/libc/issues/3772: the build script invokes rustc without properly applying the RUSTC_WRAPPER environment variable. That's a bug, it means tools that set RUSTC_WRAPPER to redirect rustc invocations somewhere else will not work properly. One such tool is rustc bootstrap; this issue blocks https://github.com/rust-lang/rust/pull/127682.

(It also seems like this crate automatically enables nightly features when built on a nightly compiler. That's a bad idea, see https://github.com/rust-lang/rust/issues/120804, https://github.com/rust-lang/rust/pull/124339, https://github.com/SergioBenitez/version_check/pull/23.)