search

stephaneey / azure-apim-extension

Full Azure API Management suite and more VSTS extension
MIT License
66 stars 48 forks source link

Option to specify different API URL suffix from Name #8

Closed DirkJelleseInh closed 6 years ago

DirkJelleseInh commented 6 years ago

When API is created Name is used in API-URL suffix, would like to gave an option to differ from name.

tomkerkhove commented 6 years ago

I'm not sure if I'm understanding your request, can you please elaborate more and/or add a screenshot?

If you want to have an api suffix on the gateway that is different from the name you can simply change that during or after creation of the api itself.

DirkJelleseInh commented 6 years ago

[cid:image001.png@01D419F8.3FFE20F0] We are deploying from a swagger file, but in the end we will get https://apitstinh.azure-api.net/tst-onderwijsinstelling/v2-api/onderwijsinstelling/onderwijseenheden.

If we can modify the base url. To test and keer the name tst-onderwijsinstellingv2-api that would be awesome. If we modify the URL in azure it still works, however next deployment the API URL suffix will be overwritten again with full name.

So only if API URL Suffix –eq “” it should copy Name, else it should use the suffix given in deployment.

Kindest Regards,

Dirk Jellese Informatie Voorziening & Technologie (IVT) – Technisch Applicatie Beheer

From: Tom Kerkhove notifications@github.com Sent: donderdag 12 juli 2018 15:40 To: stephaneey/azure-apim-extension azure-apim-extension@noreply.github.com Cc: Jellese, Dirk Dirk.Jellese@INHOLLAND.nl; Author author@noreply.github.com Subject: Re: [stephaneey/azure-apim-extension] Option to specify different API URL suffix from Name (#8)

I'm not sure if I'm understanding your request, can you please elaborate more and/or add a screenshot?

If you want to have an api suffix on the gateway that is different from the name you can simply change that during or after creation of the api itself.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/stephaneey/azure-apim-extension/issues/8#issuecomment-404515488, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AnPvOakbWGUBgoUxElgmiRCVuXNIDcoyks5uF1GwgaJpZM4VMqxR.

tomkerkhove commented 6 years ago

Unfortunately I cannot see the image that you've added but when you import - Do you do it in the portal or via PowerShell?

stephaneey commented 6 years ago

Hi,

@tomkerkhove I guess they just use my extension to deploy their API and indeed, I'm not offering any option for the API suffix as you have in the portal. I will rework the extension, you can expect to have a V2 anytime soon. I'm just back from Japan so I had no time but I will try to work on it soon.

Thanks Best Regards

DirkJelleseInh commented 6 years ago

Hello,

That would be awesome, it is our last piece of the puzzle for deployment via TFS/VSTS. I’ll try to make a public folder on my OneDrive to share the screenshots for the future.

I’m trying to get familiar with GitHub, the desktop program is not doing what it should on my laptop. I don’t know if you appreciate any extra’s via a fork, let me know. Maybe I can contribute to your great work. I use powershell a lot to make any task easier.

Kindest regards, Dirk Jellese

From: stephaneey notifications@github.com Sent: donderdag 12 juli 2018 16:49 To: stephaneey/azure-apim-extension azure-apim-extension@noreply.github.com Cc: Jellese, Dirk Dirk.Jellese@INHOLLAND.nl; Author author@noreply.github.com Subject: Re: [stephaneey/azure-apim-extension] Option to specify different API URL suffix from Name (#8)

Hi,

@tomkerkhovehttps://github.com/tomkerkhove I guess they just use my extension to deploy their API and indeed, I'm not offering any option for the API suffix as you have in the portal. I will rework the extension, you can expect to have a V2 anytime soon. I'm just back from Japan so I had no time but I will try to work on it soon.

Thanks Best Regards

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/stephaneey/azure-apim-extension/issues/8#issuecomment-404538720, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AnPvORN_8g3KaZtsmmpsocpK5KKfksgLks5uF2HIgaJpZM4VMqxR.

DirkJelleseInh commented 6 years ago

api_screen_shot

DirkJelleseInh commented 6 years ago

I added the screenshot I was talking about.

lurumad commented 6 years ago

Hi @DirkJelleseInh

Something like this

suffix

I need time to make a PR.

Regards!

DirkJelleseInh commented 6 years ago

@lurumad yes that's the part we would like to controle separate of the name

stephaneey commented 6 years ago

@DirkJelleseInh @lurumad I'm working on this, I'm fixing the easiest problems first :) but I'll definitely work on that one too.

lurumad commented 6 years ago

Hi @stephaneey

I've done this in a private branch.

Regards!

stephaneey commented 6 years ago

Hi @lurumad

Might be interesting to share so that I don't reinvent the wheel.

Thanks

lurumad commented 6 years ago

Done in #9

Regards!

stephaneey commented 6 years ago

Hello,

Great, thanks! Just published a new release on the market place.

gsscoder commented 4 years ago

I set it using New-AzApiManagementApi specifying -Path`.

The problem is that you can't left it blank, like for -ServiceUrl.

A workaround maybe using directly New-AzResource directly, but I had problems defining versions in such case.

See this S.O. question: https://stackoverflow.com/questions/60882705/azure-create-a-new-api-management-service-without-a-service-url/60962169?noredirect=1#comment107926794_60962169.