search

stephanstapel / ZUGFeRD-csharp

C# assembly for creating and reading ZUGFeRD invoices
Apache License 2.0
139 stars 79 forks source link

X-Rechnung 3.1 UBL for Deutsche Bahn - charge percentage #257

Closed stephanstapel closed 1 month ago

stephanstapel commented 2 months ago

broken down from #254, submitted by @goedo

InvoiceDescriptor22Writer.cs, 285

                            #region ChargePercentage
                            /*
                            //roger not allowed
                            if (tradeAllowanceCharge.ChargePercentage.HasValue)
                            {
                                Writer.WriteStartElement("ram:CalculationPercent", profile: Profile.Extended | Profile.XRechnung); 
                                Writer.WriteValue(_formatDecimal(tradeAllowanceCharge.ChargePercentage.Value, 2));
                                Writer.WriteEndElement();
                            }
                            */
                            #endregion
stephanstapel commented 2 months ago

@goedo: why is this not allowed?

goedo commented 2 months ago

Close the issue please.

Reason was because of the Kosit message:

image However it's only a warning, I'll keep it in mind