search

stephen-hardy / xlsx.js

XLSX.js is a JavaScript library for converting the data in base64 XLSX files into JavaScript objects - and back! Please note that this library is licensed under the Microsoft Office Extensible File License - a license NOT approved by the OSI. While this license is based off of the MS-PL, which is OSI-approved, there are significant differences.
http://blog.innovatejs.com/?tag=xlsx-js
Other
575 stars 122 forks source link

Fix number detection code #3

Closed aliasaria closed 11 years ago

aliasaria commented 11 years ago

Update number detection code to avoid false positives on some strings which are detected as numbers but are actually strings.

Example: Before, the string "650 mg" is detected as a number because:

parseInt('650 mg', 10).toString(); "650"

Now this new code properly detects it as a string

stephen-hardy commented 11 years ago

Thank you for the contribution, Ali, good catch! Pardon my delay, still learning how to administer a Git.

Thanks again, Stephen