Wrong split of sharedString in <t xml:space="preserve">foo</t>

[ghost]

I have a xlsx file containing the following XML in xl/sharedStrings.xml:

<si>
    <t xml:space="preserve">foo</t>
</si>

I have no idea for what the "preserve" tag is good for, but the sharedStrings are not split correctly:

s = zip.files['xl/sharedStrings.xml'].data.split('<t>');

I changed the code using a regex for the split:

//{ Process sharedStrings
    sharedStrings = [];
    s = zip.files['xl/sharedStrings.xml'].data.split(/<t.*?>/g);
    i = s.length;
    while(--i) { sharedStrings[i - 1] = s[i].substring(0, s[i].indexOf('</t>')); } // Do not process i === 0, because s[0] is the text before first t element
//}

Note that I also added a </t> to find the end of the string. This should work according to the following examples:

'<t xml:space="preserve">foo</t>'.split(/<t.*?>/g)
[ '', 'foo</t>' ]

'<t>foo</t>'.split(/<t.*?>/g)
[ '', 'foo</t>' ]

I changed this in my code and that was the fix for me. This seems to be an issue in both the 1.x and 2.0 version of xlsx.js.

[stephen-hardy]

Hello maitscha,

Thank you for telling us about the issue, and for contributing your fix! The "preserve" tag tells the application to preserve white space on either end of the string. It would mean the difference between " foo " and "foo". However, the tag can be present on an element representing a string without white space, without any harmful effect.

This fix will be incorporated into the next version of XLSX.js, which should be published soon.

Thanks, Stephen

[stephen-hardy]

Michl-me incorporated this fix into a pull request, which has now been merged. Thanks!

[isharamahesh]

Hi, i checked this option with your new files. I cannot find this option.