search

stephen-hardy / xlsx.js

XLSX.js is a JavaScript library for converting the data in base64 XLSX files into JavaScript objects - and back! Please note that this library is licensed under the Microsoft Office Extensible File License - a license NOT approved by the OSI. While this license is based off of the MS-PL, which is OSI-approved, there are significant differences.
http://blog.innovatejs.com/?tag=xlsx-js
Other
575 stars 122 forks source link

Bug fixes for v2.0 #6

Closed mmmichl closed 11 years ago

mmmichl commented 11 years ago

First off, thank you so much for the cool library!

As we found some issues in the current release, here is our give back. These commits should fix your open bugs #5, #4, #1 b & c. Maybe even #2.

We're looking forward what's coming next!

stephen-hardy commented 11 years ago

Hello,

You're welcome! Thanks for using our library, we LOVE hearing that!

Unfortunately, I'm going to turn down this pull request solely due to the difference in formatting for your first commit. The commit that addresses the detection of numbers, I'm guessing, is saved in a format other than Dos\Windows. The difference in line breaks leads GitHub to show every line as changed when that is only technically true, and not practically correct.

This is extremely ironic, because I just had the same thing happen to me in reverse (changed to Dos/Windows from Unix). I created a pull request for Isotope and had it rejected because it showed every line as changed. I've since created a new one, keeping with the file's format, but it has yet to be accepted. Apparently, in my case, GitHub changed the file's format when it cloned the repository locally. If I downloaded the raw js file, made my changes, and then overwrote the local file, everything worked perfectly.

So, you can submit another pull request without the format change or I can apply the changes myself. Being that I can only work on XLSX.js in short spurts, when I have time, I'll wait until Tuesday to hear back from you. Otherwise, I will commit these changes myself.

Thanks again for the participation and initiative in providing fixes for these items!