search

steven-tey / novel

Notion-style WYSIWYG editor with AI-powered autocompletion.
https://novel.sh
Apache License 2.0
12.2k stars 1.02k forks source link

Selectors show on left top in Safari #317

Closed ggukggukee closed 1 month ago

ggukggukee commented 5 months ago

Provide environment information

System: OS: macOS 14.3.1 CPU: (10) arm64 Apple M2 Pro Memory: 176.39 MB / 16.00 GB Shell: 5.9 - /bin/zsh Binaries: Node: 20.9.0 - /usr/local/bin/node npm: 10.1.0 - /usr/local/bin/npm

Describe the bug

Screenshot 2024-02-29 at 12 58 27 PM

When selecting text bubble shows up on top of text

Screenshot 2024-02-29 at 12 57 19 PM

but when you click node, link or color selector it pops up on top left corner

Link to reproduction

https://novel.sh

To reproduce

  1. Select text
  2. Click Link

Additional information

No response

sahanatvessel commented 2 months ago

@shadcn @steven-tey keen to get your eyes on to this, I think this is a combination of radix/shadcn

sahanatvessel commented 2 months ago

related: https://github.com/radix-ui/primitives/issues/2779

sahanatvessel commented 2 months ago

@ggukggukee https://github.com/ueberdosis/tiptap/discussions/4145#discussioncomment-6907839 this worked for me

JulianKominovic commented 1 month ago

@ggukggukee ueberdosis/tiptap#4145 (comment) this worked for me

Thanks @sahanatvessel.

In case this solution doesn't fit your needs you can stop using Portal. In my case Popover.Portal was the problem. Removing it solves the issue.