search

steven-tey / novel

Notion-style WYSIWYG editor with AI-powered autocompletion.
https://novel.sh
Apache License 2.0
12.7k stars 1.04k forks source link

feature: add twitter extension #407

Closed cristianrdu closed 3 months ago

cristianrdu commented 3 months ago

Hi there 👋🏻

Wanted to expand on the extensions list that the lib has by adding this twitter extension which uses https://www.npmjs.com/package/react-tweet

Please let me know what you think 😄

vercel[bot] commented 3 months ago

@cristianrdu is attempting to deploy a commit to the Dub Team on Vercel.

A member of the Team first needs to authorize it.

andrewdoro commented 3 months ago

hey bro can you also add an example on the main demo page

socket-security[bot] commented 3 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/novel@0.4.2

View full report↗︎

JasonDevTech commented 3 months ago

I think we should re-think how this package is going to be iterated on going forward - it seems like we're just adding a bunch of extensions to the headless package which is not needed. Instead, these should be released as individual extensions which users can opt into themselves and remove any they don't want (which has been a complaint of many since some extensions are hard-coded). @andrewdoro

cristianrdu commented 3 months ago

@JasonDevTech that issue should be solved with this: https://github.com/steven-tey/novel/pull/417 , extensions are removed and everyone can add them however they see fit