search

stevenlovegrove / Pangolin

Pangolin is a lightweight portable rapid development library for managing OpenGL display / interaction and abstracting video input.
MIT License
2.33k stars 845 forks source link

vcpkg pangolin build failure on Windows. #944

Open sai-yeswanth-g opened 1 month ago

sai-yeswanth-g commented 1 month ago

I tried to install pangolin using vcpkg but without adding #include <cstdint> to components\pango_image\src\image_io_bmp.cpp components\pango_image\src\image_io_jpg.cpp components\pango_image\src\image_io_bmp.cpp I can't install pangolin. otherwise the build process complains uint8_t, uint16_t and uint32_t are not declared. i'm using msys64 with gcc 14.0

christian-rauch commented 1 month ago

What exactly fails in vcpkg? The CI pipeline for Windows passes. Can you reproduce this on the CI?

sai-yeswanth-g commented 1 month ago

What exactly fails in vcpkg? The CI pipeline for Windows passes. Can you reproduce this on the CI?

the symbols mentioned are reported as undefined. I have to use mingw and I'm also new to using vcpkg. sorry that I can not provide any additional information. by including #include <cstdint> , the error goes away.

christian-rauch commented 1 month ago

Can you reproduce this on the CI and create a PR for it? Otherwise, I would close this issue unless more data on this can be gathered to reproduce.

sai-yeswanth-g commented 1 month ago

Can you reproduce this on the CI and create a PR for it? Otherwise, I would close this issue unless more data on this can be gathered to reproduce.

I'm able to build it using Cl and I saw in the readme that mingw is not supported. I'm trying to use this with godot engine and many modules and libraries are compiled with mingw, so I had to make those changes to build it using mingw. thanks for your time.

christian-rauch commented 4 weeks ago

So, this is related to MinGW and not vcpkg? This could explain why you see the issue. The CI does not test the Windows builds with MinGW. Can you send a PR with the MinGW build on Windows and your fixes?

sai-yeswanth-g commented 3 weeks ago

So, this is related to MinGW and not vcpkg? This could explain why you see the issue. The CI does not test the Windows builds with MinGW. Can you send a PR with the MinGW build on Windows and your fixes?

I can try, I'm still learning things and would need some time to properly do that.