steveohara / j2mod

Enhanced Modbus library implemented in the Java programming language
Apache License 2.0
276 stars 110 forks source link

WA9266_fix_failing_crc_check #154

Open thomas-hutterer-tik opened 5 months ago

thomas-hutterer-tik commented 5 months ago

Created a fix for https://github.com/steveohara/j2mod/issues/153 Please kindly review

steveohara commented 4 months ago

Is there any chance you can concoct a unit test case for this? Note: - The serial unit tests use a Windows serial emulator https://com0com.sourceforge.net and now (latest dev commit), they use socat to emulate comms ports on Mac/Linux