search

steves-underwater-paradise / restart-server

Minecraft Fabric mod that adds a restart command to dedicated servers.
https://www.curseforge.com/minecraft/mc-mods/restart-server
GNU Lesser General Public License v2.1
6 stars 2 forks source link

Update FAQ to mention Sinytra Connector compatability #27

Open eehunter opened 1 month ago

eehunter commented 1 month ago

The FAQ section on Modrinth says that a Forge port is not planned, however it does not mention that, based on cursory testing I have done, the mod appears to work on Forge using Sinytra Connector. I'll do further testing and update this issue if I find any bugs with it on my Connector-based pack, but as of now I can say the game loads and the restart command appears correctly.

Steveplays28 commented 1 month ago

Hi eehunter, thank you for checking! I'll add a note to the readme in a few days, when I have time.

eehunter commented 1 month ago

Actually, the restart command is present but doesn't seem to work on my forge pack. I'll close this issue for now, but I may make a pull request at some point to fix whatever is causing this.

eehunter commented 1 month ago

To elaborate, Brigader throws an error whenever I try to use the command on my forge pack. If the command is sent by an OP it's a ConcurrentModificationException, and running from the console gives a different error.

Steveplays28 commented 1 month ago

I might port the mod to (Neo)Forge eventually, would appreciate a fix in the meantime though!

eehunter commented 1 month ago

Is this mod specific to Windows? The ConcurrentModificationException happens when I run the command with a player online, but if no players are online then there's an error that says something like "no program 'cmd' can be found". My server runs Ubuntu 20.04

Steveplays28 commented 1 month ago

This mod is not specific to Windows, though you need to configure the command line to use in the config file (.minecraft/config/restart-server.json).

eehunter commented 1 month ago

Ahh, so maybe it does work on Connector. So perhaps the only issue I need to worry about patching is that ConcurrentModificationException.

Steveplays28 commented 1 month ago

Might be related to #24, which version of Minecraft are you playing on?

eehunter commented 1 month ago

1.20.1

eehunter commented 1 month ago

Actually, if I do a pull request, I bet I could add a config option so that it could automatically detect the host operating system and use the correct command by default.

Steveplays28 commented 1 month ago

Seems like it's not related to that issue I linked then. Feel free to try making a PR, would appreciate it!