WIP: BEAM Stream emotes

steveseguin / social_stream

Consolidate your live social messaging streams and much more

http://socialstream.ninja/

GNU General Public License v3.0

639 stars 93 forks source link

WIP: BEAM Stream emotes #251

Closed thexeos closed 5 months ago

thexeos commented 5 months ago

Strips style and any other future attributes set on <img /> corresponding to external emotes (e.g., Twitch/Kick/YouTube/Facebook, etc.)
Adds support for internal emotes

thexeos commented 5 months ago

I'll do it differently, which should help all extension developers that need to scrape the HTML on BEAM.

steveseguin commented 5 months ago

Reviewing this integration I see some issues, created partly by me I guess initially. Like if textonlymode is enabled, I shouldn't be using innerHTML - but instead textContent or innerText instead I think. I'm not sure if bits of other parts need escaping, for security, or whether it's good enough.

steveseguin commented 5 months ago

the content in the /sources/ folder is what I'm using going forward.

The js files in the main folder I am going to be removing over time

thexeos commented 5 months ago

I'm adding semantic markup to BEAM chat. I can see how even when we release an API some extensions would still want to scrape the HTML, so I'll be making it a little easier to do.