#1351 DoF Kernel Metadata Checks

[oakleybrunt]

Towards #1351

This PR adds metadata checks to the current LFRicKernMetadata specifically targeting dof kernel metadata. These should cover all of the rules laid out in the documentation (omitting any already covered) :

• [x] A DoF Kernel must have at least one argument that is a field. Only fields (as opposed to e.g. field vectors or operators) are accepted for DoF Kernels because only they have a single value at each DoF.

  • Covered by a) only scalars and fields accepted and b) must have one written to argument

• [x] All Kernel arguments must be either fields or scalars (real- and/or integer-valued). DoF Kernels cannot accept operators.

• [x] All field arguments to a given DoF Kernel must be on the same function space so they have the same number of DoFs.

• [x] They must have at least one modified (i.e. written to) field argument. Unlike built-ins, this is not limited and more than one modified argument is allowed.

  • This is covered by a combination of a) an kernel must have one written to argument, b) all arguments to a dof kernel must be a scalar or field, and c) scalars do not have write access for coded kernels. This means that there must always be one field with gh_write or gh_readwrite in the metadata args

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.86%. Comparing base (9f219c9) to head (94c5677). Report is 22 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2675 +/- ## ======================================= Coverage 99.86% 99.86% ======================================= Files 353 353 Lines 48962 48996 +34 ======================================= + Hits 48898 48932 +34 Misses 64 64 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[arporter]

Hi @oakleybrunt, is this ready for review now?

[oakleybrunt]

Hi @oakleybrunt, is this ready for review now?

Hey @arporter, all ready now that labels have been added to the PR 👍

[arporter]

As expected, the integration tests were green this time around :-)