stipsan / ioredis-mock

Emulates ioredis by performing all operations in-memory.
MIT License
341 stars 125 forks source link

Update ioredis-mock to support Cluster #359

Open sothychan opened 6 years ago

sothychan commented 6 years ago

Currently, ioredis-mock does not have a way to mock a Redis.Cluster set up. What's the level of effort it will take to make that happen?

stipsan commented 6 years ago

Actually not that much effort.

In a testing context RedisMock.Cluster would simply be a normal RedisMock instance but with a few extra cluster-specific commands and a few differences in how transactions and pipelines work.

Would that fit your mocking needs?

sothychan commented 6 years ago

@stipsan Yes, it would. Thank you for your quick response!

stipsan commented 6 years ago

Ok great! 😄 I’ll see if I can get it done over the weekend 🤔

  1. feb. 2018 kl. 09:36 skrev Sothy Chan notifications@github.com:

@stipsan Yes, it would. Thank you for your quick response!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

stipsan commented 6 years ago

Hey again, I didn't have time this weekend but I'll try and get it done this week 😃

Kumjami commented 6 years ago

Hi @stipsan, any progress on this? :)

Thanks for the module!

stipsan commented 6 years ago

Hey @Kumjami, I'll get to this today 😄

nabeelio commented 5 years ago

This would be great!

stipsan commented 5 years ago

I likely won't have time to work on this anytime soon, but if anyone sends in a PR I'll review it, merge and release! 😄

ofekdeitch-oligo commented 1 month ago

Hi @stipsan , I might be able to help implement this. Will you have time to review it?