search

stolostron / deploy

Deploy Development Builds of Open Cluster Management (OCM) on RedHat Openshift Container Platform
Apache License 2.0
158 stars 153 forks source link

Update nuke.sh #143

Closed hanqiuzh closed 4 years ago

hanqiuzh commented 4 years ago

added deletion of klusterlet-addon-controller webhook

Description of the change: Added deletion of klusterlet-addon-controller webhook in nuke.sh (copied & modified keyword of cert-manager webhook deletion code)

Motivation for the change: so 2.1.0 uninstall may have webhook leftover, and it blocks future reinstall & canary builds.

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hanqiuzh, jamestalton, leena-jawale To complete the pull request process, please assign You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/open-cluster-management/deploy/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment