search

stolostron / deploy

Deploy Development Builds of Open Cluster Management (OCM) on RedHat Openshift Container Platform
Apache License 2.0
158 stars 153 forks source link

Readme update to base64 encoding to avoid line breaks #154

Closed harryli256 closed 4 years ago

harryli256 commented 4 years ago

Description of the change:

Fix for downstream ACM 2.x instructions to use base64 -w 0 instead of just base64 this will ensure there are no line breaks when doing a base64 encoding on the QUAY_TOKEN.

Motivation for the change: Was causing issues when the base64 encoded value is broken up into different lines when deploying a downstream build.

harryli256 commented 4 years ago

@chrisahl Hmm, on Fedora it seems to need that, however, I'll make another revision to note that in that case. Thanks!

harryli256 commented 4 years ago

@chrisahl can you review this again? Thanks!

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chrisahl, harryli256 To complete the pull request process, please assign You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/open-cluster-management/deploy/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
harryli256 commented 4 years ago

@chrisahl Could you merge this? I don't have the permission to.

chrisahl commented 4 years ago

@harryli256 I typically leave the merges to @gurnben but maybe @Kyl-Bempah can also merge in this repo?

Kyl-Bempah commented 4 years ago

@harryli256 I typically leave the merges to @gurnben but maybe @Kyl-Bempah can also merge in this repo?

@chrisahl I can merge to every repo

harryli256 commented 4 years ago

Alright thanks @Kyl-Bempah!