search

stolostron / deploy

Deploy Development Builds of Open Cluster Management (OCM) on RedHat Openshift Container Platform
Apache License 2.0
158 stars 153 forks source link

add mce status #250

Closed cameronmwall closed 2 years ago

cameronmwall commented 2 years ago

Signed-off-by: Cameron Wall cwall@redhat.com

Description of the change: added more verbose status for the MCE subcomponents

Motivation for the change: help with the ease of debugging

gurnben commented 2 years ago

/hold

gurnben commented 2 years ago

Good catch @JakobGray - @cameronmwall can we conditionalize this on version (2.5 and up specifically) like Jakob linked?

cameronmwall commented 2 years ago

@gurnben @JakobGray thanks for the catch guys. I repeated the conditional used above in my logic

gurnben commented 2 years ago

/unhold /lgtm

gurnben commented 2 years ago

LGTM!

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cameronmwall, gurnben

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/deploy/blob/master/OWNERS)~~ [gurnben] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment