search

stolostron / multicluster-observability-operator

Operator for Multi-Cluster Monitoring with Thanos.
Apache License 2.0
125 stars 69 forks source link

update MCO cluster role for imagestreams #1594

Closed coleenquadros closed 2 months ago

coleenquadros commented 2 months ago

Initial commit for -> https://github.com/stolostron/multicluster-observability-operator/pull/1587 Since Cluster role is Managed by MCH. It needs to get updated here first. -> https://github.com/stolostron/multiclusterhub-operator/blob/main/pkg/templates/charts/toggle/multicluster-observability-operator/templates/multicluster-observability-operator-clusterrole.yaml

This is to prevent the MCO operator from failing to come up due to permission

E0829 09:17:02.982625       1 reflector.go:158] "Unhandled Error" err="pkg/mod/k8s.io/client-go@v0.31.0-alpha.2/tools/cache/reflector.go:243: Failed to watch *v1.ImageStream: failed to list *v1.ImageStream: imagestreams.image.openshift.io is forbidden: User \"system:serviceaccount:open-cluster-management:multicluster-observability-operator\" cannot list resource \"imagestreams\" in API group \"image.openshift.io\" at the cluster scope" logger="UnhandledError"
W0829 09:17:33.904106       1 reflector.go:561] pkg/mod/k8s.io/client-go@v0.31.0-alpha.2/tools/cache/reflector.go:243: failed to list *v1.ImageStream: imagestreams.image.openshift.io is forbidden: User "system:serviceaccount:open-cluster-management:multicluster-observability-operator" cannot list resource "imagestreams" in API group "image.openshift.io" at the cluster scope
sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coleenquadros, philipgough

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/multicluster-observability-operator/blob/main/OWNERS)~~ [coleenquadros,philipgough] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 months ago

New changes are detected. LGTM label has been removed.