search

stolostron / multicluster-observability-operator

Operator for Multi-Cluster Monitoring with Thanos.
Apache License 2.0
125 stars 69 forks source link

[ACM-14176]: Ensure CMO ConfigMap is reconciled on any event #1612

Closed philipgough closed 2 months ago

philipgough commented 2 months ago

Backport of https://github.com/stolostron/multicluster-observability-operator/pull/1610

  1. Adds an integration test for merging of CMO ConfigMap with other clients
  2. Adds the Delete event to the Watch for CMO ConfigMap
  3. Explicitly adds the CMO ConfigMap reference to the filtered cache
philipgough commented 2 months ago

/test test-e2e

philipgough commented 2 months ago

/retest-required

philipgough commented 2 months ago

/test test-e2e

coleenquadros commented 2 months ago

/retest

philipgough commented 2 months ago

/retest

sonarcloud[bot] commented 2 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

openshift-ci[bot] commented 2 months ago

@philipgough: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonarcloud 4acde49b8ba92c0004a105d6b57a240431bd31ed link false /test sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: philipgough, thibaultmg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/multicluster-observability-operator/blob/release-2.11/OWNERS)~~ [philipgough,thibaultmg] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment