search

stolostron / multicluster-observability-operator

Operator for Multi-Cluster Monitoring with Thanos.
Apache License 2.0
125 stars 69 forks source link

[release-2.11] Fix: sort metrics collector metrics arguments #1621

Closed openshift-cherrypick-robot closed 2 months ago

openshift-cherrypick-robot commented 2 months ago

This is an automated cherry-pick of #1618

/assign thibaultmg

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot Once this PR has been reviewed and has the lgtm label, please ask for approval from thibaultmg. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/stolostron/multicluster-observability-operator/blob/release-2.11/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sonarcloud[bot] commented 2 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

openshift-ci[bot] commented 2 months ago

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonarcloud 020c5f98a71afcb5ee6b2499e8897363666bcb92 link false /test sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).