stoneharry / WoW-Spell-Editor

A Spell Editor for WoW versions WOTLK 3.3.5, TBC 2.4.3, or Vanilla 1.12.1.
260 stars 119 forks source link

Crash when using variables with multiple string characters #214

Closed itswicky closed 1 year ago

itswicky commented 1 year ago

Spell editor version 2.11

Describe the bug There are some variables that have multiple letters, like $sp which will return an error when used in a formula and then loaded in the spell ingame description area. I.E. ${$sp * 50} because it will assume $s is the variable and then try and multiply a string, p, by an int.

To Reproduce Steps to reproduce the behavior:

  1. Edit the spell description of a spell and attempt to perform any math function with a variable that has more than one character. I.E. ${$SP * 2}.
  2. The Ingame Description window will attempt to do math on a string character.
  3. Error will occur and spell will be overwritten by the next spell you select.

Expected behavior Spell Ingame Description window should instead know that any characters following a $ sign and preceding a space is calling a variable. Some variables are 3 characters long iirc.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

stoneharry commented 1 year ago

Should be fixed in v2.2.0.