search

stonemax / acme2

Another PHP client for acme protocal (version 2) implementation, used for generating letsencrypt's free ssl certificates.
MIT License
48 stars 27 forks source link

Infinite validation instead of showing error message. #9

Closed LoranRendel closed 6 years ago

LoranRendel commented 6 years ago

When something is wrong it will never stop until PHP timeout, and no error messages will be shown.

stonemax commented 6 years ago

Hi, LoranRendel

After you has configured the web server or dns record according to challenge info, the tool will check challenge by itself fistly。

In the case of dns-01 challenge, the dns record will take a moment to take effect, so the tool must wait via an infinite loop. I don't want to set a threshold for total loop count, because the time that the dns record takes effect may be very long. But I can print some progress info to the STDOUT.

In the case of http-01, the infinite loop is unnecessary in most situations, so I will remove it.

Hope this helps you!