search

stonepillars / goon-flock

flockmind antagonist 4 goon
https://github.com/goonstation/goonstation
Other
1 stars 4 forks source link

Properly handle Flockmind and Flocktrace suicides #290

Closed FlameArrow57 closed 2 years ago

FlameArrow57 commented 2 years ago

[BUG]

About the PR

This PR adds in proper handling for Flockmind and Flocktrace suicides.

Flockminds may not suicide if the relay is up and they have no active traces available to promote. Otherwise, the Flockmind and Flocktraces may suicide at any time.

For the Flockmind, when suiciding with an active trace available, must choose one to promote to the new Flockmind before suiciding.

Two bugs are known:

  1. The Flockmind when suiciding, if there is an active trace in a Flockdrone, in admin view the Flockdrone will have the antag V symbol on it even when the Flocktrace exits. Was thinking maybe this was an issue out of scope of the PR.
  2. The "You cease to exist abruptly" message for Flocktraces suiciding is not given for when you suicide in a drone. Did not why or how to fix this.

Why's this needed?

Bug fixes, fixes #155.

stonepillars commented 2 years ago

Ignore that, meant to mention another PR. This PR has a tangentially related issue: #306