search

stonepillars / goon-flock

flockmind antagonist 4 goon
https://github.com/goonstation/goonstation
Other
1 stars 4 forks source link

Basic cleanup #294

Closed FlameArrow57 closed 2 years ago

FlameArrow57 commented 2 years ago

About the PR

This PR does some basic cleanup for Flock code.

Changes 0s and 1s to FALSE and TRUE.

Adds defines for Flockdrone resource costs.

Removes a bit of closet code that wasn't necessary any more with upstream merge.

Removes some unnecessary layers set for Flockmind and Flocktrace.

Makes deconstruction a bit more readable and uses else if rather than only ifs.

Removes a bit of code that didn't make sense.

Removes stat panels from Flockmind, Flocktrace, and Flockdrones.

Removes comments that seemed unnecessary.

Other super minor stuff.

Why's this needed?

Improved code style and removal of unnecessary stuff.

FlameArrow57 commented 2 years ago

Okay uh I just removed comments that seemed unnecessary as well as obviously not needed ones, feel free to say if I removed one that you thought should be kept

TobleroneSwordfish commented 2 years ago

Not sure how I feel about just removing every comment that isn't on a variable definition, while most of them are pretty useless, some of them provide information about intent etc. image image or a reminder of byond weirdness: image

FlameArrow57 commented 2 years ago

Sure, just comment on any cases that you feel should be kept. I removed those cases because it seemed the code nearby explained what was going on, third because it's in the reference for the function. For some cases like flock_convert_turf(), that's the only place where it's commented and it's not commented for any other uses of it.

amylizzle commented 2 years ago

One more thing I think should be included in this: the 

//TEMPORARY TEMPORARY
// TEMPORARY, I FUCKING HATE STAT PANELS

stat panel stuff. I already tested just removing it without issue, and it hasn't been useful since the TGUI panel was finished.

stonepillars commented 2 years ago

This more or less looks okay ping me if you ever want this merged because comments are subjective and I really don't care