Fixes very threatening walls

stonepillars / goon-flock

flockmind antagonist 4 goon

https://github.com/goonstation/goonstation

Other

1 stars 4 forks source link

Fixes very threatening walls #298

Closed TobleroneSwordfish closed 2 years ago

TobleroneSwordfish commented 2 years ago

[BUG]

About the PR

Fixes #295 and several adjacent bugs in flockdrone harm reporting code, including a condition which checked a proc which always returned false and the protection component mixing up thrown and projectile flags.

Why's this needed?

Walls are now far less threatening.

FlameArrow57 commented 2 years ago

See: https://github.com/stonepillars/goon-flock/pull/86

If I remember right, it was only working for point blanking or something, but don't remember exactly.

Works for pods too?

Also, idk, I think ideally reflected projectiles should be retaining their original shooter, if that's not what this does, which might just be an alternative fix?

TobleroneSwordfish commented 2 years ago

Huh weird, okay let me test it more

FlameArrow57 commented 2 years ago

Bug for future reference (very small): Reflected projectiles from non-mobs won't be reported (I don't think)

TobleroneSwordfish commented 2 years ago

Bug for future reference (very small): Reflected projectiles from non-mobs won't be reported (I don't think)

Given we can't mark a turret as an enemy it's not really an issue.

FlameArrow57 commented 2 years ago

True, was thinking more of pods

TobleroneSwordfish commented 2 years ago

True, was thinking more of pods

pods are vehicles, so should be handled fine