stonith404 / pingvin-share

A self-hosted file sharing platform that combines lightness and beauty, perfect for seamless and efficient file sharing.
https://stonith404.github.io/pingvin-share/
BSD 2-Clause "Simplified" License
3.42k stars 238 forks source link

πŸ› Bug Report: After updating the SMTP from address, emails still show the original from address #661

Open jwdoll opened 3 weeks ago

jwdoll commented 3 weeks ago

πŸ‘Ÿ Reproduction steps

Change the SMTP email address from a@domain.com to b@domain.com and email share a transfer. The email is still sent from a@domain.com.

πŸ‘ Expected behavior

The from email address for pingvin share email messages should reflect the current value saved in the config.

πŸ‘Ž Actual Behavior

When I change the SMTP email address from a@domain.com to b@domain.com, emails sent from pingvin share still come from a@domain.com. This persists across restarts and updates.

πŸ“œ Logs

No response

stonith404 commented 3 weeks ago

I can't reproduce this. Can you confirm if you changed the β€œEmail” attribute to the new email address, rather than the β€œUsername” attribute? It’s also possible that your email provider requires the sender address to match the user address.

jwdoll commented 1 week ago

Yes, I can confirm that I am changing the Email attribute rather than the Username attribute. I don't think there's a requirement that the username match the sender address with Google workspace, as the sender address that was "stuck" was already different from the username address.

I switched to using a different username/account, and was able to update the from address when I did. However, the issue persists that if I change the sender address, it seems to still be stuck on the first one used with the account.

stonith404 commented 1 week ago

You're finding some really strange bugs πŸ˜…. I have no clue why this issue happens.

The line where the β€˜From’ address header is added can be found here: https://github.com/stonith404/pingvin-share/blob/c26de4e881edfe6c7db617c0aeba89871397ebe2/backend/src/email/email.service.ts#L39-L42

If you change the application name, will it be reflected in the sent emails, or will it use the old name too?