search

stonith404 / pingvin-share

A self-hosted file sharing platform that combines lightness and beauty, perfect for seamless and efficient file sharing.
https://stonith404.github.io/pingvin-share/
BSD 2-Clause "Simplified" License
3.42k stars 238 forks source link

馃悰 Bug Report: Srpski and "小褉锌褋泻懈" languages are mixed up/bugged #664

Closed returnedinformation closed 3 weeks ago

returnedinformation commented 3 weeks ago

馃憻 Reproduction steps

When I set the language to "Srpski", which should be Serbian in Latin, it shows the app in Serbian Cyrilic When I set the language to "小褉锌褋泻懈", which should be Serbian in Cyrilic, it shows the app in English

I could really use Serbian Latin, thank you!

馃憤 Expected behavior

When I set the language to "Srpski", which should be Serbian in Latin, it shows the app in Serbian Cyrilic When I set the language to "小褉锌褋泻懈", which should be Serbian in Cyrilic, it shows the app in English

I could really use Serbian Latin, thank you!

馃憥 Actual Behavior

When I set the language to "Srpski", which should be Serbian in Latin, it shows the app in Serbian Cyrilic When I set the language to "小褉锌褋泻懈", which should be Serbian in Cyrilic, it shows the app in English

I could really use Serbian Latin, thank you!

馃摐 Logs

No response

stonith404 commented 3 weeks ago

This fix won鈥檛 have a separate release but will be included in the next one. Currently, Serbian Latin appears in English because it hasn鈥檛 been translated yet. If you鈥檇 like to help with the translation, your contribution would be greatly appreciated :)

returnedinformation commented 3 weeks ago

I see, you're missing one translation, I can help with that, at least by explaining how even you can do it. But first you need to understand...

As it is right now you have: "Srpski" and "小褉锌褋泻懈" which implies that those are Serbian Latin and Serbian Cyrilic (in that order). But your "Srpski" doesn't set the language to Serbian Latin, but sets the language to Serbian Cyrilic. Your current "Srpski" translation file should actually be "小褉锌褋泻懈", and you're actually missing the "Srpski" file/language.

Here is a tool that can transliterate between Serbian Latin and Cyrilic, so basically my help isn't even needed. https://latinicaucirilicu-rs.translate.goog/?_x_tr_sl=sr&_x_tr_tl=en&_x_tr_hl=en&_x_tr_pto=wapp But I'll make a Crowdin account and help out anyway, I can see now that you don't have a full Serbian translation yet in either of writing systems

stonith404 commented 3 weeks ago

Thanks for clarifying. I switched to labels that when you click "小褉锌褋泻懈" you get Serbian Cyrillic and when you click "Srpski" you get Serbian Latin (which is currently only English as nothing was translated yet). This is correct, right?

Regarding the translation from Serbian Cyrilic to Serbian Latin, I don't do translations in Pingvin Share, this is done by the community. Feel free to contribute to the project by filling out the Serbian translation strings on Crowdin, Crowdin doesn't require any programming skills :)

returnedinformation commented 3 weeks ago

This is correct, right?

Yep, that's correct now! I'll help out on Crowdin then, will come back here once I finish both

returnedinformation commented 1 week ago

I've translated to Serbian Cyrilic and then ran a script over it to transliterate to Latin and have uploaded it for Serbian Latin.

I'm attaching a python script I've used to transliterate it. "pip install transliterate" is required. cyr-lat.zip