storacha / w3name

IPNS client and service for generating, updating, and tracking immutable names with signed updates
Other
45 stars 12 forks source link

fix: use esbuild global values correctly #95

Closed adamalton closed 1 year ago

adamalton commented 1 year ago

Values passed in the 'define' options to esbuild become global variables, not environment variables. See: https://esbuild.github.io/api/#define

This should fix the problem of the invalid release string being passed to Sentry, as described in #86.

adamalton commented 1 year ago

I've checked in Sentry after the deployment, and there's a new entry in there which doesn't show this problem, so this looks like it's fixed it 👍 .