Do not overwrite CPPFLAGS

storaged-project / udisks

The UDisks project provides a daemon, tools and libraries to access and manipulate disks, storage devices and technologies.

https://storaged.org/doc/udisks2-api/latest/

Other

348 stars 142 forks source link

Closed mbiebl closed 4 months ago

mbiebl commented 4 months ago

Use AM_CPPFLAGS instead of ovewriting CPPFLAGS. CPPFLAGS is a user variable reserved for local modifications. See https://www.gnu.org/software/automake/manual/html_node/Flag-Variables-Ordering.html

StorageGhoul commented 4 months ago

Can one of the admins verify this patch?

mbiebl commented 4 months ago

In Debian we pass certain hardening build flags to all packages and I was wondering why that failed for udisks: https://salsa.debian.org/utopia-team/udisks2/-/jobs/5927192

Turns out that the udisks build system uses CPPFLAGS whereas it should use AM_CPPFLAGS

vojtechtrefny commented 4 months ago

Jenkins, ok to test.