brodycj
commented
4 years ago Thanks @ekrapfl for reporting. I can now reproduce the crash with the following test case (also with 150 properties & 5000 rows):
it(suiteName + 'INSERT JSON TEXT string many rows with hundred properties each & SELECT the data', function(done) {
var db = openDatabase('INSERT-JSON-TEXT-string-many-rows-with-hundred-properties.db')
var test_rows = 7000
var test_props = 100
db.transaction(function(tx) {
tx.executeSql('DROP TABLE IF EXISTS test_table');
tx.executeSql('CREATE TABLE IF NOT EXISTS test_table (data)', [], function(ignored1, ignored2) {
for (var id=0; id<test_rows; ++id) {
var obj = {}
obj.id = id;
for (var i=0; i<test_props; ++i) {
// [TBD] NO CRASH REPRODUCED WITH THIS CASE:
// obj['prop'+i] = 'value-'+(1000+i)
// XXX CRASH REPRODUCED IN THIS CASE (value with 50 chars):
obj['prop'+i] = 'value-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa-'+(1000+i)
}
var insert_data = JSON.stringify(obj)
tx.executeSql('INSERT INTO test_table VALUES (?)', [insert_data])
}
tx.executeSql('INSERT INTO test_table VALUES (?)', ['{extra:true}'], function(tx_ignored, rs1) {
expect(rs1).toBeDefined();
expect(rs1.rowsAffected).toBe(1);
tx.executeSql('SELECT data FROM test_table', [], function(tx_ignored, rs2) {
expect(rs2).toBeDefined();
expect(rs2.rows).toBeDefined();
// expect(rs2.rows.length).toBe(???);
var row = rs2.rows.item(0);
expect(row.data).toBeDefined() // [TBD (...)]
done();
});
});
});
}, function(error) {
// NOT EXPECTED:
expect(false).toBe(true);
expect(error.message).toBe('---');
// Close (plugin only) & finish:
(isWebSql) ? done() : db.close(done, done);
});
}, MYTIMEOUT);I will need some time to investigate this one. At this point I am thinking to look for a solution on the evcore (brodysoft/cordova-sqlite-evcore-extbuild-free) plugin version.
I am attempting to run a select statement like so (using
executeSqland no transaction):The
datacolumn is a JSON column that contains a fairly wide JSON object for each row (call it about 150 properties on each object)When I have about 6000 records in the table, this will crash on Android, pretty consistently. The error log that I get is as follows:
The number of records that causes the crash will vary based on how wide the records are (fewer properties on the JSON object will allow for more records to be selected), and it will also vary if I do other memory intensive things within the app before having the select statement run.
I have tried this using both cordova-sqlite-ext and cordova-sqlite-evcore-extbuild-free with the same results. I see no significant improvement in the cordova-sqlite-evcore-extbuild-free version.
I certainly could (and probably should) add an upper limit to the SELECT, but I am concerned with the relatively low amount of records I am selecting to cause this crash. Any guidance would be appreciated.
Eben
Possibly related to #55